mower.js ➔ describe(ꞌMowerꞌ) - Code Metrics - Inspection of "Remove validation types for move prototype" - Huljo/MowItNow - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (b787eb)

by Joss

created 2016-06-05 06:36 UTC

mower.js ➔ describe(ꞌMowerꞌ) B

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	64
Ratio	71.11 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
c	1
b	0
f	0
nc	1
nop	0
dl	64
loc	90
rs	8.5454

How to fix Long Method

'use strict';

var expect = require('expect.js');

var Position = require('../lib/position');
var Grid = require('../lib/grid');
var Mower = require('../lib/mower');

describe('Mower', function() {
    describe('start', function () {

        var grid = new Grid(new Position({x:5,y:5}, 'N'));
        it('should stop at positon 1 3 N', function (done) {
            var position = new Position({x:1,y:2}, 'N'),
                mower = new Mower(0, grid, position, ['G','A','G','A','G','A','G','A','A']);
            mower.start().then(function(mowerUpdated) {
                expect(mowerUpdated.position).to.eql({ x:1, y:3, c:'N' });
                done();
            });
        });
        it('should stop at positon 4 1 E', function (done) {
            var position = new Position({x:3,y:3}, 'E'),
                mower = new Mower(0, grid, position, ['A','D','A','A','D','A','D','D','A']);
            mower.start().then(function(mowerUpdated) {
                expect(mowerUpdated.position).to.eql({ x:4, y:1, c:'E' });
                done();
            });
        });
        it('should stop at positon 5 4 N', function (done) {
            var position = new Position({x:5,y:2}, 'S'),
                mower = new Mower(0, grid, position, ['A','G','A','G','A','A','D','A','G','A']);
            mower.start().then(function(mowerUpdated) {
                expect(mowerUpdated.position).to.eql({ x:5, y:4, c:'N' });
                done();
            });
        });

    });
    describe('runStep', function () {

        var grid = new Grid(new Position({x:10,y:10}, 'N'));
        it('should stop at positon 3 2 E', function (done) {
            var position = new Position({x:2,y:2}, 'E');
            var mower = new Mower(0, grid, position, ['A']);
            mower.runStep(0,function(mowerUpdated) {
                expect(mowerUpdated.position).to.eql({ x:3, y:2, c:'E' });
                done();
            });
        });
        it('should stop at positon 1 2 W', function (done) {
            var position = new Position({x:2,y:2}, 'W'),
                mower = new Mower(0, grid, position, ['A']);
            mower.runStep(0,function(mowerUpdated) {
                expect(mowerUpdated.position).to.eql({ x:1, y:2, c:'W' });
                done();
            });
        });
        it('should stop at positon 2 3 N', function (done) {
            var position = new Position({x:2,y:2}, 'N'),
                mower = new Mower(0, grid, position, ['A']);
            mower.runStep(0,function(mowerUpdated) {
                expect(mowerUpdated.position).to.eql({ x:2, y:3, c:'N' });
                done();
            });
        });
        it('should stop at positon 2 1 S', function (done) {
            var position = new Position({x:2,y:2}, 'S'),
                mower = new Mower(0, grid, position, ['A']);
            mower.runStep(0,function(mowerUpdated) {
                expect(mowerUpdated.position).to.eql({ x:2, y:1, c:'S' });
                done();
            });
        });

    });
    describe('isValid', function () {
        var grid = new Grid(new Position({x:8,y:8}, 'N')),
            position = new Position({x:3,y:3}, 'E');
        it('should throw an error when ID is not valid', function () {
            expect(function() {
                new Mower(false, grid, position, ['A']);
            }).to.throwException(/Id is not valid/);
        });
        it('should throw an error when GRID is not valid', function () {
            expect(function() {
                new Mower(0, false, position, ['A']);
            }).to.throwException(/Grid is not valid/);
        });
        it('should throw an error when POSITION is not valid', function () {
            expect(function() {
                new Mower(0, grid, false, ['A']);
            }).to.throwException(/Position is not valid/);
        });
        it('should throw an error when INSTRUCTIONS are not valid', function () {
            expect(function() {
                new Mower(0, grid, position, false);
            }).to.throwException(/Instructions are not valid/);
        });
    });
});

1		'use strict';
2
3		var expect = require('expect.js');
4
5		var Position = require('../lib/position');
6		var Grid = require('../lib/grid');
7		var Mower = require('../lib/mower');
8
9		describe('Mower', function() {
10	View Code Duplication	describe('start', function () {
		0 ignored issues – show Duplication introduced 2016-06-05 01:36 UTC by Report Bug Copy Issue Report This code seems to be duplicated in your project. Loading history...
11		var grid = new Grid(new Position({x:5,y:5}, 'N'));
12		it('should stop at positon 1 3 N', function (done) {
13		var position = new Position({x:1,y:2}, 'N'),
14		mower = new Mower(0, grid, position, ['G','A','G','A','G','A','G','A','A']);
15		mower.start().then(function(mowerUpdated) {
16		expect(mowerUpdated.position).to.eql({ x:1, y:3, c:'N' });
17		done();
18		});
19		});
20		it('should stop at positon 4 1 E', function (done) {
21		var position = new Position({x:3,y:3}, 'E'),
22		mower = new Mower(0, grid, position, ['A','D','A','A','D','A','D','D','A']);
23		mower.start().then(function(mowerUpdated) {
24		expect(mowerUpdated.position).to.eql({ x:4, y:1, c:'E' });
25		done();
26		});
27		});
28		it('should stop at positon 5 4 N', function (done) {
29		var position = new Position({x:5,y:2}, 'S'),
30		mower = new Mower(0, grid, position, ['A','G','A','G','A','A','D','A','G','A']);
31		mower.start().then(function(mowerUpdated) {
32		expect(mowerUpdated.position).to.eql({ x:5, y:4, c:'N' });
33		done();
34		});
35		});
36
37		});
38	View Code Duplication	describe('runStep', function () {
		0 ignored issues – show Duplication introduced 2016-06-05 01:36 UTC by Report Bug Copy Issue Report This code seems to be duplicated in your project. Loading history...
39		var grid = new Grid(new Position({x:10,y:10}, 'N'));
40		it('should stop at positon 3 2 E', function (done) {
41		var position = new Position({x:2,y:2}, 'E');
42		var mower = new Mower(0, grid, position, ['A']);
43		mower.runStep(0,function(mowerUpdated) {
44		expect(mowerUpdated.position).to.eql({ x:3, y:2, c:'E' });
45		done();
46		});
47		});
48		it('should stop at positon 1 2 W', function (done) {
49		var position = new Position({x:2,y:2}, 'W'),
50		mower = new Mower(0, grid, position, ['A']);
51		mower.runStep(0,function(mowerUpdated) {
52		expect(mowerUpdated.position).to.eql({ x:1, y:2, c:'W' });
53		done();
54		});
55		});
56		it('should stop at positon 2 3 N', function (done) {
57		var position = new Position({x:2,y:2}, 'N'),
58		mower = new Mower(0, grid, position, ['A']);
59		mower.runStep(0,function(mowerUpdated) {
60		expect(mowerUpdated.position).to.eql({ x:2, y:3, c:'N' });
61		done();
62		});
63		});
64		it('should stop at positon 2 1 S', function (done) {
65		var position = new Position({x:2,y:2}, 'S'),
66		mower = new Mower(0, grid, position, ['A']);
67		mower.runStep(0,function(mowerUpdated) {
68		expect(mowerUpdated.position).to.eql({ x:2, y:1, c:'S' });
69		done();
70		});
71		});
72
73		});
74		describe('isValid', function () {
75		var grid = new Grid(new Position({x:8,y:8}, 'N')),
76		position = new Position({x:3,y:3}, 'E');
77		it('should throw an error when ID is not valid', function () {
78		expect(function() {
79		new Mower(false, grid, position, ['A']);
80		}).to.throwException(/Id is not valid/);
81		});
82		it('should throw an error when GRID is not valid', function () {
83		expect(function() {
84		new Mower(0, false, position, ['A']);
85		}).to.throwException(/Grid is not valid/);
86		});
87		it('should throw an error when POSITION is not valid', function () {
88		expect(function() {
89		new Mower(0, grid, false, ['A']);
90		}).to.throwException(/Position is not valid/);
91		});
92		it('should throw an error when INSTRUCTIONS are not valid', function () {
93		expect(function() {
94		new Mower(0, grid, position, false);
95		}).to.throwException(/Instructions are not valid/);
96		});
97		});
98		});

Huljo / MowItNow

GitHub Access Token became invalid

Branch — master (b787eb)

mower.js ➔ describe(ꞌMowerꞌ) B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like